janhoy commented on a change in pull request #1083: SOLR-13662: Fixes to
package manager
URL: https://github.com/apache/lucene-solr/pull/1083#discussion_r357939014
##########
File path:
solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java
##########
@@ -148,7 +167,7 @@ private boolean deployPackage(SolrPackageInstance
packageInstance, boolean pegTo
// Get package params
try {
- boolean packageParamsExist =
((Map)PackageUtils.getJson(solrClient.getHttpClient(), solrBaseUrl +
"/api/collections/abc/config/params/packages", Map.class)
+ boolean packageParamsExist =
((Map)PackageUtils.getJson(solrClient.getHttpClient(), solrBaseUrl +
"/api/collections/"+collection+"/config/params/packages", Map.class)
Review comment:
Static path names such as `/api/collections` and also
`/config/params/packages` shold be well defined constants, not loose strings. I
see them repeated many places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
