janhoy commented on a change in pull request #1083: SOLR-13662: Fixes to
package manager
URL: https://github.com/apache/lucene-solr/pull/1083#discussion_r357938502
##########
File path:
solr/core/src/java/org/apache/solr/packagemanager/DefaultPackageRepository.java
##########
@@ -82,7 +82,7 @@ public boolean hasPackage(String packageName) {
public Path download(String artifactName) throws SolrException, IOException {
Path tmpDirectory = Files.createTempDirectory("solr-packages");
tmpDirectory.toFile().deleteOnExit();
- URL url = new URL(new URL(repositoryURL), artifactName);
+ URL url = new URL(new URL(repositoryURL.endsWith("/")? repositoryURL:
repositoryURL+"/"), artifactName);
String fileName = url.getPath().substring(url.getPath().lastIndexOf('/') +
1);
Review comment:
Can replace custom logic with `FilenameUtils.getName(url.getPath())`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
