dweiss commented on issue #1070: LUCENE-9089: FST Builder fluent-style constructor. URL: https://github.com/apache/lucene-solr/pull/1070#issuecomment-564432652 This is a builder-on-builder now. :) We should have used a different name for the "compiler" of FSTs then it could become: FST FSTCompiler FSTCompiler.Builder and then: FSTCompiler.build() -> FSTCompiler.Builder.build() -> FSTCompiler().[add()*|build()] -> FST But it looks like a nice improvement even now!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
