[
https://issues.apache.org/jira/browse/SOLR-13970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16992876#comment-16992876
]
Joel Bernstein edited comment on SOLR-13970 at 12/10/19 7:31 PM:
-----------------------------------------------------------------
Added a test, and removed a test that was specifically exercising collapse and
grouping.
That test was way back in Solr 4.7 as part this ticket:
https://issues.apache.org/jira/browse/SOLR-5230.
Back then it was probably fine to have collapse and grouping together because
the caches they rely on had a random access API. When the DocValues went to the
iterator API collapse and grouping no longer worked anymore because grouping
calls the same postfilter twice without resetting the internal state of the
DocValues cache, which breaks things.
In a separate ticket we should inventory which postfilters use the DocValues
caches during collect() and make sure they all throw exceptions when used with
grouping.
was (Author: joel.bernstein):
Added a test, and removed a test that was specifically exercising collapse and
grouping.
That test was way back in Solr 4.7 as part this ticket:
https://issues.apache.org/jira/browse/SOLR-5230.
Back then it was probably fine to have collapse and grouping together because
the caches they rely on had a random access API. When the DocValues went to the
iterator API collapse and grouping no longer worked anymore because grouping
calls the same postfilter twice without resetting the internal state of the
DocValues cache, which breaks things.
In a separate ticket we should inventory which postfilters use the DocValues
caches during collect() and make sure they are through exceptions when used
with grouping.
> Collapse/Expand and Grouping are not designed to work together, we should
> fail requests that specify both gracefully
> --------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-13970
> URL: https://issues.apache.org/jira/browse/SOLR-13970
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Erick Erickson
> Assignee: Munendra S N
> Priority: Major
> Attachments: SOLR-13970.patch, SOLR-13970.patch, SOLR-13970.patch
>
>
> Expand/Collapse was conceived as orthogonal to grouping, and there are odd
> interactions when both are specified. If these two options are specified, we
> should reject the query with an informative message.
> Shorter term, making this explicit in the documents would be helpful.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
