[
https://issues.apache.org/jira/browse/SOLR-13970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16986104#comment-16986104
]
Erick Erickson edited comment on SOLR-13970 at 12/2/19 2:54 PM:
----------------------------------------------------------------
[~munendrasn] I _very_ briefly looked it over, but haven't been involved in
that code, I raised the JIRA because we see so many user-list mentions of this
and Joel seemed to think it was a good idea.
[~jbernste], can you take a look? It looks pretty straightforward.
On my brief review it looks good, but as I said that's not code I'm familiar
with.
I followed the link for the AwaitsFix annotation you removed that we no longer
need (SOLR-11974) which lists these apparently related (didn't check
personally) JIRAs: SOLR-9104, SOLR-10336, SOLR-7435. Maybe we can close all
11974 and the mentioned JIRAs too?
Oh, and many thanks for doing this!
was (Author: erickerickson):
[~munendrasn] I _very_ briefly looked it over, but haven't been involved in
that code, I raised the JIRA because we see so many user-list mentions of this
and Joel seemed to think it was a good idea.
[~jbernste], can you take a look? It looks pretty straightforward.
On my brief review it looks good, but as I said that's not code I'm familiar
with.
I followed the link for the AwaitsFix annotation you removed that we no longer
need (SOLR-11974) which lists these apparently related (didn't check
personally) JIRAs: SOLR-9104, SOLR-10336, SOLR-7435. Maybe we can close all
11974 and the mentioned JIRAs too?
> Collapse/Expand and Grouping are not designed to work together, we should
> fail requests that specify both gracefully
> --------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-13970
> URL: https://issues.apache.org/jira/browse/SOLR-13970
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Erick Erickson
> Priority: Major
> Attachments: SOLR-13970.patch
>
>
> Expand/Collapse was conceived as orthogonal to grouping, and there are odd
> interactions when both are specified. If these two options are specified, we
> should reject the query with an informative message.
> Shorter term, making this explicit in the documents would be helpful.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
