praste commented on a change in pull request #153: Fix issues reported by
findbugs
URL: https://github.com/apache/lucene-solr/pull/153#discussion_r352319352
##########
File path:
solr/contrib/extraction/src/java/org/apache/solr/handler/extraction/XLSXResponseWriter.java
##########
@@ -357,7 +357,7 @@ public void writeArray(String name, Iterator val) throws
IOException {
if (v instanceof IndexableField) {
IndexableField f = (IndexableField)v;
if (v instanceof Date) {
- output.append(((Date) val).toInstant().toString() + "; ");
+ output.append(((Date) v).toInstant().toString() + "; ");
Review comment:
I have not seen this in the logs.
I hit some weird error a few years back and I couldn’t believe how that we
have such blatant bugs in the code all over that I ran findbugs and started
wack-a-mole game for all the bugs reported.
I don’t remember what the original bug was anymore. I will give this a
second shot and I will put small patches for each type of error reported by
findbugs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
