[
https://issues.apache.org/jira/browse/SOLR-13946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16977937#comment-16977937
]
Chris M. Hostetter commented on SOLR-13946:
-------------------------------------------
Looking back at [~jdyer]'s comments in SOLR-5344, i realize now that the reason
93d1e67886e7 impacted this test seed is because SpellCheckCollator uses
{{SolrIndexSearcher.TERMINATE_EARLY}} when {{spellcheck.collateMaxCollectDocs}}
is used.
Fundementally, i think these assertions are just flawed given that a random
merge policy can result in docs in any order – so all of the {{everyother}}
docs could wind up at the begining of the index, split across 2 segments. the
first segment could contain exactly 5 docs, all of which might have that term –
so the EarlyTerminatingCollector will abort with numberScanned=5,
numberCollected=5 and the hueristic will think every doc in the (incredibly
tiny) index is a match.
(See also SOLR-5344 still being re-opened and the record of similar reproducing
seeds in the past)
i *think* the test might work "as designed" if we forced in order merges ... or
we could just change the assertions: when {{spellcheck.collateMaxCollectDocs}}
is >= the actual number of docs that match, then the hits should be exact.
otherwise the only thing we can really say for sure is that the lower bound
should be at least as high as {{spellcheck.collateMaxCollectDocs}} and the
upper bound should never be more then the # of docs in the index.
> SpellCheckCollatorTest.testEstimatedHitCounts reproducing failure seed
> ----------------------------------------------------------------------
>
> Key: SOLR-13946
> URL: https://issues.apache.org/jira/browse/SOLR-13946
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Chris M. Hostetter
> Priority: Major
>
> The following seed reliably fails on branch_8x. based on the results of git
> bisect, it appears that this in some way relates to changes made in
> LUCENE-8660 (TopDocsCollectors's accuracy in reporting totalHits when dealing
> with totalHitsThreshold) even though all usage in sol should be requesting
> {{totalHitsThreshold=Integer.MAX_VALUE}}
> {noformat}
> [junit4] 2> NOTE: reproduce with: ant test
> -Dtestcase=SpellCheckCollatorTest -Dtests.method=testEstimatedHitCounts
> -Dtests.seed=AFA731DEE618DA14 -Dtests.multiplier=2 -Dtests.nightly=true
> -Dtests.slow=true -Dtests.badapples=true -Dtests.locale=ga-IE
> -Dtests.timezone=Canada/Atlantic -Dtests.asserts=true
> -Dtests.file.encoding=UTF-8
> [junit4] ERROR 0.36s | SpellCheckCollatorTest.testEstimatedHitCounts <<<
> [junit4] > Throwable #1: java.lang.RuntimeException: Exception during
> query
> [junit4] > at
> __randomizedtesting.SeedInfo.seed([AFA731DEE618DA14:9E1C8FEB4327CAC4]:0)
> [junit4] > at
> org.apache.solr.SolrTestCaseJ4.assertQ(SolrTestCaseJ4.java:1001)
> [junit4] > at
> org.apache.solr.SolrTestCaseJ4.assertQ(SolrTestCaseJ4.java:961)
> [junit4] > at
> org.apache.solr.spelling.SpellCheckCollatorTest.testEstimatedHitCounts(SpellCheckCollatorTest.java:569)
> [junit4] > at java.lang.Thread.run(Thread.java:748)
> [junit4] > Caused by: java.lang.RuntimeException: REQUEST FAILED:
> xpath=//lst[@name='spellcheck']/lst[@name='collations']/lst[@name='collation']/long[@name='hits'
> and 3 <= . and . <= 13]
> [junit4] > xml response was: <?xml version="1.0" encoding="UTF-8"?>
> [junit4] > <response>
> [junit4] > <lst name="responseHeader"><int name="status">0</int><int
> name="QTime">2</int></lst><result name="response" numFound="0"
> start="0"></result><lst name="spellcheck"><lst name="suggestions"><lst
> name="everother"><int name="numFound">1</int><int
> name="startOffset">9</int><int name="endOffset">18</int><arr
> name="suggestion"><str>everyother</str></arr></lst></lst><lst
> name="collations"><lst name="collation"><str
> name="collationQuery">teststop:everyother</str><long
> name="hits">14</long><lst name="misspellingsAndCorrections"><str
> name="everother">everyother</str></lst></lst></lst></lst>
> [junit4] > </response>
> [junit4] > request
> was:spellcheck=true&spellcheck.dictionary=direct&spellcheck.count=1&spellcheck.collate=true&spellcheck.maxCollationTries=1&spellcheck.maxCollations=1&spellcheck.collateExtendedResults=true&qt=/spellCheckCompRH&q=teststop:everother&spellcheck.collateMaxCollectDocs=5
> [junit4] > at
> org.apache.solr.SolrTestCaseJ4.assertQ(SolrTestCaseJ4.java:994)
> [junit4] > ... 41 more
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
