[ https://issues.apache.org/jira/browse/SOLR-13911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16972056#comment-16972056 ]
Chris M. Hostetter commented on SOLR-13911: ------------------------------------------- Munendra: I skimmed your patch w/o testing it in depth - it al seems straight forward and logical to me, allthough i have a few of the same concerns as i mentioned in SOLR-13912: * new aggregations need to be covered in the ref guide: https://lucene.apache.org/solr/guide/8_2/json-facet-api.html#stat-facet-functions * as noted in the parent issue SOLR-11695 we have existing commented out test coverage adapted from legacy facts+stats testing that refers to "{{// TODO: SOLR-\11695}}" in java comments – if we're adding this functionality now, then those tests should be un-commented (and pass) > Support missing() aggregation in JSON facet module > -------------------------------------------------- > > Key: SOLR-13911 > URL: https://issues.apache.org/jira/browse/SOLR-13911 > Project: Solr > Issue Type: Sub-task > Components: Facet Module > Reporter: Munendra S N > Priority: Major > Attachments: SOLR-11695.patch, SOLR-13911.patch, SOLR-13911.patch > > > Add {{missing()}} aggregation in JSON Facet module similar to > StatsComponent's missing -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org