chatman commented on a change in pull request #994: SOLR-13662: Package Manager (CLI) URL: https://github.com/apache/lucene-solr/pull/994#discussion_r342171287
########## File path: solr/core/ivy.xml ########## @@ -138,6 +138,10 @@ <dependency org="com.google.protobuf" name="protobuf-java" rev="${/com.google.protobuf/protobuf-java}" conf="compile"/> <dependency org="com.jayway.jsonpath" name="json-path" rev="${/com.jayway.jsonpath/json-path}" conf="compile"/> + <dependency org="com.github.zafarkhaja" name="java-semver" rev="0.9.0" conf="compile"/> + <dependency org="net.minidev" name="json-smart" rev="2.2.1" conf="compile"/> + <dependency org="net.minidev" name="asm" rev="1.0.2" conf="compile"/> Review comment: There's a problem including asm here. This is needed for semver to work. Will look at some solution to fix this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org