atris commented on a change in pull request #815: LUCENE-8213: Introduce
Asynchronous Caching in LRUQueryCache
URL: https://github.com/apache/lucene-solr/pull/815#discussion_r326578335
##########
File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java
##########
@@ -832,5 +894,25 @@ public BulkScorer bulkScorer(LeafReaderContext context)
throws IOException {
return new DefaultBulkScorer(new ConstantScoreScorer(this, 0f,
ScoreMode.COMPLETE_NO_SCORES, disi));
}
+ // Perform a cache load asynchronously
+ private void cacheAsynchronously(LeafReaderContext context,
IndexReader.CacheHelper cacheHelper) throws IOException {
+ FutureTask<Void> task = new FutureTask<>(() -> {
+ DocIdSet localDocIdSet = cache(context);
+ putIfAbsent(in.getQuery(), localDocIdSet, cacheHelper);
+
+ //remove the key from inflight -- the key is loaded now
+ inFlightAsyncLoadQueries.remove(in.getQuery());
+ return null;
+ });
+ /*
+ * If the current query is already being asynchronously cached,
+ * do not trigger another cache operation
+ */
+ if (inFlightAsyncLoadQueries.contains(in.getQuery())) {
+ return;
+ }
+ inFlightAsyncLoadQueries.add(in.getQuery());
Review comment:
I was hesitant to do that since that would entail moving out the addition of
the entry in the map from the actual triggering of cache load. However, there
is minimal risk involved in decoupling these two, and will indeed safeguard us
completely from two threads caching the same query. Fixed and updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
