rdblue commented on code in PR #7992: URL: https://github.com/apache/iceberg/pull/7992#discussion_r1254817163
########## api/src/main/java/org/apache/iceberg/view/UpdateViewRepresentation.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.view; + +import org.apache.iceberg.PendingUpdate; +import org.apache.iceberg.catalog.Namespace; + +/** + * API for updating a view representation. + * + * <p>Apply returns the updated view for validation. + * + * <p>When committing, these changes will be applied to the current view metadata. Commit conflicts + * will be resolved by applying the pending changes to the new view metadata. + */ +public interface UpdateViewRepresentation extends PendingUpdate<ViewVersion> { Review Comment: > The semantics of .replace() at the View API level should mean that previously configured representations and properties are carried over. Yes, this is what we do for tables. If you want to erase the history, then you can drop and re-create the object. > we can probably remove the UpdateViewRepresentation I think we should remove this. What we want instead is a way to replace the version, like `newVersion()` or `replaceVersion()`. I think that has mostly the same API as the `ViewBuilder`, probably through a shared interface like `ViewVersionBuilder` that has all the version-related methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
