nastra commented on code in PR #7992: URL: https://github.com/apache/iceberg/pull/7992#discussion_r1254081793
########## api/src/main/java/org/apache/iceberg/view/UpdateViewRepresentation.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.view; + +import org.apache.iceberg.PendingUpdate; +import org.apache.iceberg.catalog.Namespace; + +/** + * API for updating a view representation. + * + * <p>Apply returns the updated view for validation. + * + * <p>When committing, these changes will be applied to the current view metadata. Commit conflicts + * will be resolved by applying the pending changes to the new view metadata. + */ +public interface UpdateViewRepresentation extends PendingUpdate<ViewVersion> { Review Comment: > One more thing: this may actually be dangerous with multiple people interacting. If you replace a view with a new query at the same time that I add a dialect to the old verison, we could end up mixing SQL that doesn't produce the same result. Modifying any of this would write a new view version id and conflict detection would detect that the base view version of the second update changed (that's how it's currently implemented in https://github.com/apache/iceberg/pull/7913) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
