nastra commented on code in PR #7992:
URL: https://github.com/apache/iceberg/pull/7992#discussion_r1254112125


##########
api/src/main/java/org/apache/iceberg/view/SQLViewRepresentation.java:
##########
@@ -37,17 +36,7 @@ default String type() {
   /** The view query SQL dialect. */
   String dialect();
 
-  /** The default catalog when the view is created. */
-  @Nullable
-  String defaultCatalog();

Review Comment:
   hm good point, should we maybe store `defaultCatalog` at the `ViewVersion` 
level in this case (same as the `defaultNamespace`?)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to