skytin1004 commented on code in PR #7861:
URL: https://github.com/apache/iceberg/pull/7861#discussion_r1238736242
##########
core/src/test/java/org/apache/iceberg/hadoop/TestHadoopTables.java:
##########
@@ -83,36 +76,32 @@ public void testDropTable() {
@Test
public void testDropTableWithPurge() throws IOException {
- File dataDir = temp.newFolder();
- createDummyTable(tableDir, dataDir);
+ createDummyTable(tableDir, dataDir.toFile());
Review Comment:
I've changed dataDir to File instead of Path
##########
core/src/test/java/org/apache/iceberg/hadoop/HadoopFileIOTest.java:
##########
@@ -111,16 +110,16 @@ public void testDeletePrefix() {
hadoopFileIO.deletePrefix(scalePath.toUri().toString());
// Hadoop filesystem will throw if the path does not exist
- assertThrows(
- UncheckedIOException.class,
- () ->
hadoopFileIO.listPrefix(scalePath.toUri().toString()).iterator());
+ Assertions.assertThatThrownBy(
+ () ->
hadoopFileIO.listPrefix(scalePath.toUri().toString()).iterator())
+ .isInstanceOf(UncheckedIOException.class);
Review Comment:
Based on your review, I've added the `.hasMessage(...)` in
`Assertions.assertThatThrownBy` .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
