skytin1004 commented on code in PR #7861:
URL: https://github.com/apache/iceberg/pull/7861#discussion_r1238759449
##########
core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCatalog.java:
##########
@@ -530,13 +533,14 @@ public void testTableName() throws Exception {
catalog.buildTable(tableIdent, SCHEMA).withPartitionSpec(SPEC).create();
Table table = catalog.loadTable(tableIdent);
- Assert.assertEquals("Name must match", "hadoop.db.ns1.ns2.tbl",
table.name());
+ Assertions.assertThat(table.name()).as("Name must
match").isEqualTo("hadoop.db.ns1.ns2.tbl");
Review Comment:
Based on your review, I've removed unnecessary descriptions.
##########
core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCatalog.java:
##########
@@ -267,13 +273,11 @@ public void testListTables() throws Exception {
List<TableIdentifier> tbls1 = catalog.listTables(Namespace.of("db"));
Set<String> tblSet = Sets.newHashSet(tbls1.stream().map(t ->
t.name()).iterator());
- Assert.assertEquals(2, tblSet.size());
- Assert.assertTrue(tblSet.contains("tbl1"));
- Assert.assertTrue(tblSet.contains("tbl2"));
+ Assertions.assertThat(tblSet).hasSize(2).contains("tbl1").contains("tbl2");
List<TableIdentifier> tbls2 = catalog.listTables(Namespace.of("db",
"ns1"));
- Assert.assertEquals("table identifiers", 1, tbls2.size());
- Assert.assertEquals("table name", "tbl3", tbls2.get(0).name());
+ Assertions.assertThat(tbls2).as("table identifiers").hasSize(1);
Review Comment:
Based on your review, I've removed unnecessary descriptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
