nastra commented on code in PR #7861:
URL: https://github.com/apache/iceberg/pull/7861#discussion_r1238674431
##########
core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCatalog.java:
##########
@@ -267,13 +273,11 @@ public void testListTables() throws Exception {
List<TableIdentifier> tbls1 = catalog.listTables(Namespace.of("db"));
Set<String> tblSet = Sets.newHashSet(tbls1.stream().map(t ->
t.name()).iterator());
- Assert.assertEquals(2, tblSet.size());
- Assert.assertTrue(tblSet.contains("tbl1"));
- Assert.assertTrue(tblSet.contains("tbl2"));
+ Assertions.assertThat(tblSet).hasSize(2).contains("tbl1").contains("tbl2");
List<TableIdentifier> tbls2 = catalog.listTables(Namespace.of("db",
"ns1"));
- Assert.assertEquals("table identifiers", 1, tbls2.size());
- Assert.assertEquals("table name", "tbl3", tbls2.get(0).name());
+ Assertions.assertThat(tbls2).as("table identifiers").hasSize(1);
Review Comment:
nit: the `.as(..)` part here is meaningless and can be removed. Same for the
`.as("table name")`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
