nastra commented on code in PR #7861:
URL: https://github.com/apache/iceberg/pull/7861#discussion_r1238478352
##########
core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCatalog.java:
##########
@@ -69,10 +68,10 @@ public void testCreateTableBuilder() throws Exception {
.withProperties(ImmutableMap.of("key2", "value2"))
.create();
- Assert.assertEquals(TABLE_SCHEMA.toString(), table.schema().toString());
- Assert.assertEquals(1, table.spec().fields().size());
- Assert.assertEquals("value1", table.properties().get("key1"));
- Assert.assertEquals("value2", table.properties().get("key2"));
+
Assertions.assertThat(table.schema().toString()).isEqualTo(TABLE_SCHEMA.toString());
+ Assertions.assertThat(table.spec().fields()).hasSize(1);
+ Assertions.assertThat(table.properties().get("key1")).isEqualTo("value1");
Review Comment:
those should all be `.containsEntry` (please also double-check other places
that are being modified as part of this PR so that we use the same mechanism
everywhere)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
