skytin1004 commented on code in PR #7861:
URL: https://github.com/apache/iceberg/pull/7861#discussion_r1238385936
##########
core/src/test/java/org/apache/iceberg/rest/RequestResponseTestBase.java:
##########
@@ -76,11 +75,13 @@ public void testHasOnlyKnownFields() {
try {
JsonNode node = mapper().readValue(serialize(createExampleInstance()),
JsonNode.class);
for (String field : fieldsFromSpec) {
- Assert.assertTrue("Should have field: " + field, node.has(field));
+ Assertions.assertThat(node.has(field)).as("Should have field: %s",
field).isTrue();
}
for (String field : ((Iterable<? extends String>) node::fieldNames)) {
- Assert.assertTrue("Should not have field: " + field,
fieldsFromSpec.contains(field));
+ Assertions.assertThat(fieldsFromSpec.contains(field))
Review Comment:
I modified the code based on the method you presented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
