skytin1004 commented on code in PR #7861:
URL: https://github.com/apache/iceberg/pull/7861#discussion_r1238261542
##########
core/src/test/java/org/apache/iceberg/hadoop/TestStaticTable.java:
##########
@@ -88,13 +87,13 @@ public void testHasSameProperties() {
table.newAppend().appendFile(FILE_B).commit();
table.newOverwrite().deleteFile(FILE_B).addFile(FILE_C).commit();
Table staticTable = getStaticTable();
- Assert.assertTrue("Same history?",
table.history().containsAll(staticTable.history()));
- Assert.assertTrue(
- "Same snapshot?",
- table.currentSnapshot().snapshotId() ==
staticTable.currentSnapshot().snapshotId());
- Assert.assertTrue(
- "Same properties?",
- Maps.difference(table.properties(),
staticTable.properties()).areEqual());
+ Assertions.assertThat(table.history()).as("Same
history?").containsAll(staticTable.history());
+ Assertions.assertThat(table.currentSnapshot().snapshotId())
+ .as("Same snapshot?")
+ .isEqualTo(staticTable.currentSnapshot().snapshotId());
+ Assertions.assertThat(Maps.difference(table.properties(),
staticTable.properties()).areEqual())
Review Comment:
I've modified that code based on what you suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
