aokolnychyi commented on code in PR #7651:
URL: https://github.com/apache/iceberg/pull/7651#discussion_r1199499158
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -246,12 +246,21 @@ protected void add(DataFile file) {
/** Add a delete file to the new snapshot. */
protected void add(DeleteFile file) {
- Preconditions.checkNotNull(file, "Invalid delete file: null");
Review Comment:
The check moved to the `DeleteFileHolder` constructor, but is present in
only one of two constructors now. It would be more explicit in `add`, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
