aokolnychyi commented on code in PR #7651:
URL: https://github.com/apache/iceberg/pull/7651#discussion_r1199495995
##########
api/src/main/java/org/apache/iceberg/RewriteFiles.java:
##########
@@ -97,6 +97,22 @@ default RewriteFiles addFile(DeleteFile deleteFile) {
this.getClass().getName() + " does not implement addFile");
}
+ /**
+ * Add a new delete file with the given data sequence number.
+ *
+ * <p>This rewrite operation may change the size or layout of the delete
files. When applicable,
+ * it is also recommended to discard delete records for files that are no
longer part of the table
+ * state. However, the set of applicable delete records must never change.
Review Comment:
Can we add a note explaining that when rewriting position delete files, the
sequence number of the new file must be the max sequence number of the original
files? We may want to note that rewriting equality deletes that belong to
different data sequence numbers is not allowed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
