rdblue commented on code in PR #7651:
URL: https://github.com/apache/iceberg/pull/7651#discussion_r1199491515
##########
api/src/main/java/org/apache/iceberg/RewriteFiles.java:
##########
@@ -97,6 +97,22 @@ default RewriteFiles addFile(DeleteFile deleteFile) {
this.getClass().getName() + " does not implement addFile");
}
+ /**
+ * Add a new delete file with the given data sequence number.
+ *
+ * <p>This rewrite operation may change the size or layout of the delete
files. When applicable,
+ * it is also recommended to discard delete records for files that are no
longer part of the table
+ * state. However, the set of applicable delete records must never change.
+ *
+ * @param deleteFile a new delete file
+ * @param dataSequenceNumber data sequence number to append on the file
+ * @return this for method chaining
+ */
+ default RewriteFiles addFile(DeleteFile deleteFile, long dataSequenceNumber)
{
Review Comment:
Yeah, cherry picking seems like a case where we'd have the wrong sequence
number. The good news is that we don't allow cherry picking unless the commit
is an append or a dynamic partition overwrite. Otherwise we lose too much
information.
I'm also a bit concerned about letting sequence number on the file be used.
I'd probably opt to ignore it and have an explicit sequence number in the API
like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
