aokolnychyi commented on code in PR #7637:
URL: https://github.com/apache/iceberg/pull/7637#discussion_r1199452910
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/TestSparkDistributionAndOrderingUtil.java:
##########
@@ -1386,14 +1801,27 @@ public void
testRangeCopyOnWriteMergePartitionedSortedTable() {
// Distribution and ordering for merge-on-read DELETE operations with
position deletes
//
===================================================================================
//
- // delete mode is NOT SET -> CLUSTER BY _spec_id, _partition + LOCALLY ORDER
BY _spec_id,
- // _partition, _file, _pos
- // delete mode is NONE -> unspecified distribution + LOCALLY ORDER BY
_spec_id, _partition, _file,
- // _pos
- // delete mode is HASH -> CLUSTER BY _spec_id, _partition + LOCALLY ORDER BY
_spec_id, _partition,
- // _file, _pos
+ // UNPARTITIONED (ORDERED & UNORDERED)
+ // -------------------------------------------------------------------------
+ // delete mode is NOT SET -> CLUSTER BY _spec_id, _partition, _file +
Review Comment:
Adding `_file` to the clustering for unpartitioned tables as `spec_id`,
`_partition` will be the same for all rows and deletes for the same data file
may end up in multiple delete files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
