rdblue commented on code in PR #7637:
URL: https://github.com/apache/iceberg/pull/7637#discussion_r1199838415


##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java:
##########
@@ -622,8 +590,7 @@ private static class UnpartitionedDeltaWriter extends 
DeleteAndDataDeltaWriter {
 
     @Override
     public void update(InternalRow meta, InternalRow id, InternalRow row) 
throws IOException {
-      delete(meta, id);
-      delegate.update(row, dataSpec, null);
+      throw new UnsupportedOperationException("Update must be represented as 
delete and insert");

Review Comment:
   This makes me happy that we actually write updates as separate deletes and 
inserts.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to