aokolnychyi commented on code in PR #7637:
URL: https://github.com/apache/iceberg/pull/7637#discussion_r1199411557
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/TestSparkDistributionAndOrderingUtil.java:
##########
@@ -326,16 +445,41 @@ public void testRangeWritePartitionedSortedTable() {
checkWriteDistributionAndOrdering(table, expectedDistribution,
expectedOrdering);
}
+ @Test
+ public void testRangeWritePartitionedSortedTableFanout() {
+ sql(
+ "CREATE TABLE %s (id BIGINT, data STRING, date DATE, ts TIMESTAMP) "
+ + "USING iceberg "
+ + "PARTITIONED BY (date)",
+ tableName);
+
+ Table table = validationCatalog.loadTable(tableIdent);
+
+ table.replaceSortOrder().asc("id").commit();
+
+ table.updateProperties().set(SPARK_WRITE_PARTITIONED_FANOUT_ENABLED,
"true").commit();
+
+ SortOrder[] expectedOrdering =
+ new SortOrder[] {
+ Expressions.sort(Expressions.column("date"),
SortDirection.ASCENDING),
+ Expressions.sort(Expressions.column("id"), SortDirection.ASCENDING)
+ };
+
+ Distribution expectedDistribution =
Distributions.ordered(expectedOrdering);
+
+ checkWriteDistributionAndOrdering(table, expectedDistribution,
expectedOrdering);
+ }
+
// =============================================================
// Distribution and ordering for copy-on-write DELETE operations
// =============================================================
//
// UNPARTITIONED UNORDERED
// -------------------------------------------------------------------------
- // delete mode is NOT SET -> CLUSTER BY _file + LOCALLY ORDER BY _file, _pos
+ // delete mode is NOT SET -> CLUSTER BY _file + empty ordering
Review Comment:
Same as for appends.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
