aokolnychyi commented on code in PR #7565:
URL: https://github.com/apache/iceberg/pull/7565#discussion_r1194612323
##########
core/src/main/java/org/apache/iceberg/util/StructLikeMap.java:
##########
@@ -171,4 +172,10 @@ public R setValue(R value) {
throw new UnsupportedOperationException("Does not support setValue.");
}
}
+
+ public <U> StructLikeMap<U> transformValues(Function<T, U> func) {
Review Comment:
Your idea of making this a static method also makes sense to me. It would be
more in line with Guava and other similar libs. If you decide to make it
static, keep in mind the ordering of methods. Static methods should be right
after the constructor.
```
public static <T, U> StructLikeMap<U> transformValues(StructLikeMap<T> map,
Function<T, U> func) {
...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
