aokolnychyi commented on code in PR #7565:
URL: https://github.com/apache/iceberg/pull/7565#discussion_r1189238658
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/actions/RewritePositionDeleteFilesSparkAction.java:
##########
@@ -298,7 +311,7 @@ private Result doExecuteWithPartialProgress(
.run(fileGroup -> commitService.offer(rewriteDeleteFiles(ctx,
fileGroup)));
rewriteService.shutdown();
- // Stop Commit service
+ // stop commit service
Review Comment:
Can we also slightly restructure `toGroupStream`? Spotless formatted it in a
weird way. Should it also be private?
```
private Stream<RewritePositionDeletesGroup> toGroupStream(
RewriteExecutionContext ctx,
StructLikeMap<List<List<PositionDeletesScanTask>>> groupsByPartition) {
return groupsByPartition.entrySet().stream()
.flatMap(
entry -> {
StructLike partition = entry.getKey();
List<List<PositionDeletesScanTask>> fileGroups =
entry.getValue();
return fileGroups.stream().map(tasks -> newRewriteGroup(ctx,
partition, tasks));
})
.sorted(RewritePositionDeletesGroup.comparator(rewriteJobOrder));
}
private RewritePositionDeletesGroup newRewriteGroup(
RewriteExecutionContext ctx, StructLike partition,
List<PositionDeletesScanTask> tasks) {
...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
