gaborkaszab commented on code in PR #7555:
URL: https://github.com/apache/iceberg/pull/7555#discussion_r1189776432
##########
api/src/main/java/org/apache/iceberg/ContentFile.java:
##########
@@ -113,6 +113,16 @@ default Integer sortOrderId() {
return null;
}
+ /** Returns the data sequence number of the snapshot in which the file
should be applied. */
+ default Long dataSequenceNumber() {
+ return null;
+ }
+
+ /** Returns the file sequence number. */
Review Comment:
Sure, thanks for the suggestion. The comments I added to ContentFile are
indeed a bit light. My thinking was that I didn't want to duplicate the
comments from ManifestEntry, but you're right, it makes sense to be verbose
with the comments in ContentFile as well.
I merge the 2 proposals above and added to the function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
