aokolnychyi commented on code in PR #7555:
URL: https://github.com/apache/iceberg/pull/7555#discussion_r1194486831
##########
core/src/test/java/org/apache/iceberg/TableTestBase.java:
##########
@@ -410,11 +410,19 @@ void validateSnapshot(Snapshot old, Snapshot snap, Long
sequenceNumber, DataFile
if (sequenceNumber != null) {
V1Assert.assertEquals(
"Data sequence number should default to 0", 0,
entry.dataSequenceNumber().longValue());
+ V1Assert.assertEquals(
+ "Data sequence number should default to 0",
Review Comment:
@gaborkaszab, you are correct that rewrites may preserve the initial data
sequence number. This method would not work for such rewrites. I believe we
have other tests that pass an iterator of sequence numbers that should be used
in those cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
