aokolnychyi commented on code in PR #7555:
URL: https://github.com/apache/iceberg/pull/7555#discussion_r1188047485
##########
core/src/test/java/org/apache/iceberg/TableTestBase.java:
##########
@@ -562,6 +544,44 @@ void validateDeleteManifest(
Assert.assertFalse("Should find all files in the manifest",
expectedFiles.hasNext());
}
+ private <T extends ContentFile<T>> void validateManifestSequenceNumbers(
Review Comment:
This is a good way to test the core logic. Shall we also add tests at a
higher level? For instance, it would be great to check methods for
added/removed files in `Snapshot` behave correctly or that files returned via
scans also have this information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
