emkornfield commented on code in PR #7504:
URL: https://github.com/apache/iceberg/pull/7504#discussion_r1186341567
##########
format/view-spec.md:
##########
@@ -328,3 +330,17 @@
s3://bucket/warehouse/default.db/event_agg/metadata/00002-(uuid).metadata.json
} ]
}
```
+
+## Appendix B: Well Known (canonical) dialects
+
+The following dialects names are reserved and indicate dialects for specific
systems:
+
+| Dialect Name | Description
| Versioning |
+|--------------|-------------------------------------------------------------------------------------------------------|-------------|
+|athena | [Amazon Athena
Dialect](https://docs.aws.amazon.com/athena/latest/ug/ddl-sql-reference.html)
| TBD |
+|google_sql | [Google's SQL
Dialect](https://cloud.google.com/bigquery/docs/reference/standard-sql/query-syntax)
| TBD |
+|spark | [Apache Spark SQL
Dialect](https://spark.apache.org/docs/latest/sql-ref-ansi-compliance.html)
| TBD |
+|trino | [Trino SQL
Dialect](https://trino.io/docs/current/language.html)
| TBD |
+
+Dialect names starting with "iceberg." are reserved for future extension. Well
known dialects
+may be added in the future with the prefix of "iceberg." (E.g.
"iceberg.new_dialect_name").
Review Comment:
It is likely an edge case, but this prevents dialect name conflicts for
people that choose a not already reserved dialect.
Another way of saying this is once the spec becomes official people are free
to use any non-reserved name, and ideally change in the OSS library should not
break those people if they follow the specification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
