emkornfield commented on code in PR #7504:
URL: https://github.com/apache/iceberg/pull/7504#discussion_r1184102178
##########
format/view-spec.md:
##########
@@ -328,3 +330,17 @@
s3://bucket/warehouse/default.db/event_agg/metadata/00002-(uuid).metadata.json
} ]
}
```
+
+## Appendix B: Well Known (canonical) dialects
+
+The following dialects names are reserved and indicate dialects for specific
systems:
+
+| Dialect Name | Description
| Versioning |
+|--------------|-------------------------------------------------------------------------------------------------------|-------------|
+|athena | [Amazon Athena
Dialect](https://docs.aws.amazon.com/athena/latest/ug/ddl-sql-reference.html)
| TBD |
Review Comment:
Potentially, maybe we can get someone from AWS to weigh in.
https://docs.aws.amazon.com/athena/latest/ug/engine-versions-reference-0003.html
mentions both trino and presto, since the projects are forked its not clear to
me if this should be considered a hybrid of the two (and if presto should be
included in this list as well). I think there are likely other systems we will
want to add here before the spec is officially ratified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
