wypoon commented on code in PR #7469:
URL: https://github.com/apache/iceberg/pull/7469#discussion_r1184300768
##########
spark/v3.1/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -457,6 +459,13 @@ public final void initialize(String name,
CaseInsensitiveStringMap options) {
PropertyUtil.propertyAsBoolean(
options, CatalogProperties.CACHE_ENABLED,
CatalogProperties.CACHE_ENABLED_DEFAULT);
+ SparkSession sparkSession = SparkSession.active();
+ boolean cacheCaseSensitive =
+ PropertyUtil.propertyAsBoolean(
+ options,
+ CatalogProperties.CACHE_CASE_SENSITIVE,
+
Boolean.parseBoolean(sparkSession.conf().get("spark.sql.caseSensitive")));
Review Comment:
I could add the `caseSensitive(SparkSession)` helper method to `SparkUtil`
in 3.1 as well, but where do I stop? Do I then go on to rewrite the other
places in 3.1 that should then use this helper instead? I didn't do so because
this would touch more files unrelated to this change. @szehon-ho let me know
what you prefer.
Note: The helper method was introduced in
https://github.com/apache/iceberg/pull/6899 in 3.3, which was backported to 3.2
but not 3.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
