szehon-ho commented on code in PR #7469:
URL: https://github.com/apache/iceberg/pull/7469#discussion_r1184353752
##########
spark/v3.1/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -457,6 +459,13 @@ public final void initialize(String name,
CaseInsensitiveStringMap options) {
PropertyUtil.propertyAsBoolean(
options, CatalogProperties.CACHE_ENABLED,
CatalogProperties.CACHE_ENABLED_DEFAULT);
+ SparkSession sparkSession = SparkSession.active();
+ boolean cacheCaseSensitive =
+ PropertyUtil.propertyAsBoolean(
+ options,
+ CatalogProperties.CACHE_CASE_SENSITIVE,
+
Boolean.parseBoolean(sparkSession.conf().get("spark.sql.caseSensitive")));
Review Comment:
Yea, i would say if its just a few lines, add the method to SparkUtil and
then use it here, so at least this code is same across three versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
