wypoon commented on code in PR #7469:
URL: https://github.com/apache/iceberg/pull/7469#discussion_r1184092083
##########
core/src/main/java/org/apache/iceberg/CatalogProperties.java:
##########
@@ -41,6 +41,11 @@ private CatalogProperties() {}
public static final boolean CACHE_ENABLED_DEFAULT = true;
+ /** Controls whether the caching catalog will cache table entries using
case-sensitive keys. */
+ public static final String CACHE_CASE_SENSITIVE = "cache.case-sensitive";
+
+ public static final boolean CACHE_CASE_SENSITIVE_DEFAULT = false;
Review Comment:
@RussellSpitzer I had not understood what you meant.
@szehon-ho I have now updated the PR.
Assuming caching is enabled, the behavior is as follows:
If the user configures `cache.case-sensitive`, the conf is used. Otherwise,
the case sensitivity of `CachingCatalog` is set to match
`spark.sql.caseSensitive` in the runtime configuration of the `SparkSession`.
Thus we have configurability as well as a default that should match users'
expectations. In practice, `spark.sql.caseSensitive` should rarely be set (and
thus default to false), as the Spark documentation for it advises, "It is
highly discouraged to turn on case sensitive mode."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
