jackye1995 commented on code in PR #7505:
URL: https://github.com/apache/iceberg/pull/7505#discussion_r1184194984
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -1179,9 +1127,12 @@ public void setClientRegion(String clientRegion) {
*/
public <T extends S3ClientBuilder> void applyS3CredentialConfigurations(T
builder) {
Review Comment:
for these classes, my thought is that we can make them static methods taking
multiple properties classes. This probably means we should have another PR to
at least separate out the `HttpClientProperties` and `AwsClientProperties`.
Before that, we can keep these methods as is for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
