jackye1995 commented on code in PR #7505:
URL: https://github.com/apache/iceberg/pull/7505#discussion_r1184192814
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -985,35 +933,35 @@ public String clientAssumeRoleSessionName() {
}
public String s3FileIoSseType() {
- return s3FileIoSseType;
+ return s3FileIOProperties.s3FileIoSseType();
Review Comment:
similar to the comment about variables, we should also just mark these
methods as deprecated, with javadoc saying which version will this be removed.
Overall my thought is that we should not have nested properties. We will have
fully separated properties classes, similar to the `XXXConfig` in Trino, that
seems to be pretty neat.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
