jackye1995 commented on code in PR #7505:
URL: https://github.com/apache/iceberg/pull/7505#discussion_r1183908678
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -69,46 +69,46 @@ public class AwsProperties implements Serializable {
*
* <p>For more details:
https://docs.aws.amazon.com/AmazonS3/latest/dev/serv-side-encryption.html
*/
- public static final String S3FILEIO_SSE_TYPE = "s3.sse.type";
+ public static final String S3FILEIO_SSE_TYPE =
S3FileIOProperties.S3FILEIO_SSE_TYPE;
Review Comment:
I think we can just mark these properties as deprecated? Not sure if we
should remove it at 2.0 or 1.4 though, given this is a pretty big change, 2.0
is probably better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
