rdblue commented on code in PR #7128:
URL: https://github.com/apache/iceberg/pull/7128#discussion_r1155392300
##########
core/src/main/java/org/apache/iceberg/LocationProviders.java:
##########
@@ -167,5 +169,17 @@ private static String pathContext(String tableLocation) {
return resolvedContext;
}
+
+ private static String computeHash(String fileName) {
+ Preconditions.checkState(fileName != null, "fileName cannot be null");
Review Comment:
This would be an argument problem, not a state problem. Also, I don't think
the right place for this check is in a private static util method. User-facing
methods may want to do this (but don't, so probably not) but it isn't a good
idea to check it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
