danielcweeks commented on code in PR #7128:
URL: https://github.com/apache/iceberg/pull/7128#discussion_r1142689597
##########
core/src/main/java/org/apache/iceberg/LocationProviders.java:
##########
@@ -167,5 +169,18 @@ private static String pathContext(String tableLocation) {
return resolvedContext;
}
+
+ private static String computeHash(String fileName) {
Review Comment:
@singhpk234 It looks like you resolved this, but I think we still need to
address the `=` case. I assume we can just pad the bytes to make sure we don't
have URL padding.
##########
core/src/main/java/org/apache/iceberg/LocationProviders.java:
##########
@@ -167,5 +169,18 @@ private static String pathContext(String tableLocation) {
return resolvedContext;
}
+
+ private static String computeHash(String fileName) {
Review Comment:
@singhpk234 It looks like you resolved this, but I think we still need to
address the `=` case. I assume we can just pad the bytes to make sure we don't
have Base64 URL padding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
