rdblue commented on code in PR #7128:
URL: https://github.com/apache/iceberg/pull/7128#discussion_r1156117428
##########
core/src/main/java/org/apache/iceberg/LocationProviders.java:
##########
@@ -104,9 +106,11 @@ public String newDataLocation(String filename) {
}
static class ObjectStoreLocationProvider implements LocationProvider {
- private static final Function<Object, Integer> HASH_FUNC =
- Transforms.bucket(Integer.MAX_VALUE).bind(Types.StringType.get());
+ private static final HashFunction HASH_FUNC = Hashing.murmur3_32_fixed();
+ private static final BaseEncoding BASE64_ENCODER =
+ BaseEncoding.base64Url().lowerCase().omitPadding();
Review Comment:
@singhpk234, it is a bug that I used `lowerCase` here. The build is failing
because base64 encoding requires both lower and upper case letters. Can you fix
the build by removing this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
