lirui-apache commented on code in PR #6698:
URL: https://github.com/apache/iceberg/pull/6698#discussion_r1145916257
##########
core/src/main/java/org/apache/iceberg/CatalogProperties.java:
##########
@@ -119,6 +119,26 @@ private CatalogProperties() {}
"client.pool.cache.eviction-interval-ms";
public static final long CLIENT_POOL_CACHE_EVICTION_INTERVAL_MS_DEFAULT =
TimeUnit.MINUTES.toMillis(5);
+ /**
+ * A comma separated list of elements used, in addition to the hive
metastore uri, to compose the
Review Comment:
Hmm, I think key is generic enough for a cache, but what can be used to
compose the key is implementation dependent. How about we leave the config in
`CatalogProperties` like this:
```java
/**
* A comma separated list of elements used, in addition to the {@link
#URI}, to compose the
* key of the client pool cache.
*
* <p>Supported key elements in a Catalog are implementation-dependent.
*/
public static final String CLIENT_POOL_CACHE_KEYS =
"client-pool-cache-keys";
```
Then we move the rest of the javadoc to `CachedClientPool`. Will that be
clearer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
