lirui-apache commented on code in PR #6698: URL: https://github.com/apache/iceberg/pull/6698#discussion_r1132042821
########## core/src/main/java/org/apache/iceberg/CatalogProperties.java: ########## @@ -119,6 +119,26 @@ private CatalogProperties() {} "client.pool.cache.eviction-interval-ms"; public static final long CLIENT_POOL_CACHE_EVICTION_INTERVAL_MS_DEFAULT = TimeUnit.MINUTES.toMillis(5); + /** + * A comma separated list of elements that are used to compose the key of the client pool cache. + * + * <p>The following elements are supported: + * + * <ul> + * <li>URI - as specified by {@link CatalogProperties#URI}. URI will be the only element when + * this property is not set. + * <li>UGI - the Hadoop UserGroupInformation instance that represents the current user using the + * cache. + * <li>USER_NAME - similar to UGI but only includes the user's name determined by + * UserGroupInformation#getUserName. + * <li>CONF - name of an arbitrary configuration. The value of the configuration will be Review Comment: OK. The implementation is actually case-insensitive. I don't have a strong opinion whether to use upper or lower case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org