lirui-apache commented on code in PR #6698:
URL: https://github.com/apache/iceberg/pull/6698#discussion_r1133431221
##########
core/src/main/java/org/apache/iceberg/CatalogProperties.java:
##########
@@ -119,6 +119,26 @@ private CatalogProperties() {}
"client.pool.cache.eviction-interval-ms";
public static final long CLIENT_POOL_CACHE_EVICTION_INTERVAL_MS_DEFAULT =
TimeUnit.MINUTES.toMillis(5);
+ /**
+ * A comma separated list of elements that are used to compose the key of
the client pool cache.
+ *
+ * <p>The following elements are supported:
+ *
+ * <ul>
+ * <li>URI - as specified by {@link CatalogProperties#URI}. URI will be
the only element when
Review Comment:
@szehon-ho A common way to achieve impersonation is to create proxy users
using the engine's principal. But different UGI instances cannot be equivalent,
even though they actually represent the same user. E.g. the following two proxy
users are different:
```java
UserGroupInformation foo1 = UserGroupInformation.createProxyUser("foo",
current);
UserGroupInformation foo2 = UserGroupInformation.createProxyUser("foo",
current);
```
And if we use the above UGIs in the cache key, `foo1` and `foo2` won't be
able to share the underlying connection pool. This may or may not be desirable,
given how an engine/service manages UGI instances. That's why I think both UGI
and USER_NAME can be useful. But I'm also OK if we just keep UGI and add other
options as we have new requirements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
