dpaani commented on code in PR #7128:
URL: https://github.com/apache/iceberg/pull/7128#discussion_r1142652440


##########
core/src/main/java/org/apache/iceberg/LocationProviders.java:
##########
@@ -143,11 +143,11 @@ public String newDataLocation(PartitionSpec spec, 
StructLike partitionData, Stri
 
     @Override
     public String newDataLocation(String filename) {
-      int hash = HASH_FUNC.apply(filename);
+      String hash = computeHash(filename);

Review Comment:
   hi @jackye1995 if a object storage path has millions of files, S3 listing 
usually takes very long time since it has to go thru all the keys recursively.  
This behavior can be improved by listing files with hash prefix in parallel 
like <location>/data/00, <location>/data/01, <location>/data/0a etc. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to