rdblue commented on code in PR #7128:
URL: https://github.com/apache/iceberg/pull/7128#discussion_r1141162359
##########
core/src/main/java/org/apache/iceberg/LocationProviders.java:
##########
@@ -167,5 +169,18 @@ private static String pathContext(String tableLocation) {
return resolvedContext;
}
+
+ private static String computeHash(String fileName) {
Review Comment:
This is okay, but I generally prefer using a library, like the URL-safe
base64 variant. To avoid `=`, I think we can make the encoded value a multiple
of 3 bytes long. Then we just add - and _.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
