jackye1995 commented on code in PR #7128:
URL: https://github.com/apache/iceberg/pull/7128#discussion_r1140687948
##########
core/src/main/java/org/apache/iceberg/LocationProviders.java:
##########
@@ -104,9 +104,11 @@ public String newDataLocation(String filename) {
}
static class ObjectStoreLocationProvider implements LocationProvider {
- private static final Function<Object, Integer> HASH_FUNC =
- Transforms.bucket(Integer.MAX_VALUE).bind(Types.StringType.get());
+ private static final HashFunction HASH_FUNC = Hashing.sha1();
Review Comment:
Thought about this a bit more. There is a performance implication of using
SHA1. Can we continue to use MurMur3 which is fast? It can produce a 128bit
hash, and we can convert that to a base64 URL safe string using
`Base64.getUrlEncoder().encodeToString(hash)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
