ajantha-bhat commented on code in PR #6789:
URL: https://github.com/apache/iceberg/pull/6789#discussion_r1138312883
##########
nessie/src/main/java/org/apache/iceberg/nessie/UpdateableReference.java:
##########
@@ -60,13 +60,6 @@ public String getHash() {
return reference.getHash();
}
- public Branch getAsBranch() {
Review Comment:
> This method a safe cast
because all the places where this was called, already there is a check for
`getRef().checkMutable()`. So, no need for one more method call that checks if
it is a branch. Hence, directly casting to branch.
I will remove `isBranch` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
