dimas-b commented on code in PR #6789: URL: https://github.com/apache/iceberg/pull/6789#discussion_r1161830915
########## nessie/src/main/java/org/apache/iceberg/nessie/UpdateableReference.java: ########## @@ -60,13 +60,6 @@ public String getHash() { return reference.getHash(); } - public Branch getAsBranch() { Review Comment: nit: how about returning a `Branch` from `checkMutable` to avoid type casts in the calling code? (just a thought, no need to delay this PR because of this). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org