danielcweeks commented on code in PR #7064:
URL: https://github.com/apache/iceberg/pull/7064#discussion_r1132734422
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -98,6 +98,7 @@ public class RESTSessionCatalog extends BaseSessionCatalog
OAuth2Properties.SAML1_TOKEN_TYPE);
private final Function<Map<String, String>, RESTClient> clientBuilder;
+ private Function<Map<String, String>, FileIO> ioBuilder;
Review Comment:
nit: we've got a weird mix of explicitly initializing some members to `null`
and other's relying on the implicit initialization (e.g. here is implicit and
in the `io` member above it's explicit). I've vote for just not setting the
value to null since that's the expected and well understood behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
